[SPARK-57500][SQL] Escape backslash in MySQL JDBC pushdown for string literals in comparison/IN predicates#56558
Draft
jiwen624 wants to merge 1 commit into
Draft
Conversation
… literals in comparison/IN predicates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
MySQL treats
\as an escape character inside string literals.MySQLDialect.escapeSqlnow doubles backslashes (on top of the base single-quote doubling). To avoid double-escaping,JDBCSQLBuilder.buildnow rendersSTARTS_WITH/ENDS_WITH/CONTAINSfrom the raw literal value through the sameescapeSql.With this fix every literal pushed through
compileValue(=,<>,<,<=,>,>=,IN, ...) can be parsed correctly.Why are the changes needed?
Fix the issue that
WHERE c = 'a\b'was pushed to MySQL as`c` = 'a\b', which MySQL parses as`c` = 'a<backspace>', silently dropping the matching row (wrong results).This is the comparison/
INsibling of SPARK-57332, which fixed only the LIKE family. Standard-SQL dialects are unaffected.Does this PR introduce any user-facing change?
Yes - fixing JDBC pushdown for string literals with escape backslash for IN/comparison.
How was this patch tested?
Added UT cases
Was this patch authored or co-authored using generative AI tooling?
Yes. Claude Code